EIP-2935: Serve historical block hashes from state #953
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 146 146
Lines 15439 15456 +17
=======================================
+ Hits 14488 14505 +17
Misses 951 951
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
added a commit
that referenced
this pull request
Aug 19, 2024
This is blockchain tests execution optimization: only check state root hash of first 5 blocks (to detect early problems) and last 5 blocks (to do the final check of the chain of blocks). The current implementation of the MPT hash of the state builds the trie from scratch (no updates to the trie of the previous block). For the tests will a long chain of blocks the performance degrades significantly with 99% time spent in the keccak hash function. This improves testing of EIP-2935 implemented in #953.
chfast
force-pushed
the
eip2935_blockhash_history
branch
from
126d592
to
63f4ff0
Compare
pdobacz
reviewed
Aug 20, 2024
pdobacz
reviewed
Aug 20, 2024
pdobacz
approved these changes
Aug 20, 2024
chfast
force-pushed
the
eip2935_blockhash_history
branch
from
63f4ff0
to
d8a314b
Compare
gumb0
approved these changes
Aug 22, 2024
chfast
force-pushed
the
eip2935_blockhash_history
branch
from
5d5ed72
to
3612132
Compare
chfast
added a commit
that referenced
this pull request
Sep 10, 2024
This is blockchain tests execution optimization: for listed test names only check state root hash of first 5 blocks (to detect early problems) and last 5 blocks (to do the final check of the chain of blocks). The current implementation of the MPT hash of the state builds the trie from scratch (no updates to the trie of the previous block). For the tests will a long chain of blocks the performance degrades significantly with 99% time spent in the keccak hash function. This improves testing of EIP-2935 implemented in #953.
chfast
added a commit
that referenced
this pull request
Sep 10, 2024
This is blockchain tests execution optimization: for listed test names only check state root hash of first 5 blocks (to detect early problems) and last 5 blocks (to do the final check of the chain of blocks). The current implementation of the MPT hash of the state builds the trie from scratch (no updates to the trie of the previous block). For the tests will a long chain of blocks the performance degrades significantly with 99% time spent in the keccak hash function. This improves testing of EIP-2935 implemented in #953.
chfast
force-pushed
the
eip2935_blockhash_history
branch
2 times, most recently
from
c3ad014
to
b5f9990
Compare
chfast
force-pushed
the
eip2935_blockhash_history
branch
from
b5f9990
to
645756f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement EIP-2935 "Serve historical block hashes from state" required for the Prague revision.
This mostly adds new system contract.