blockchaintest: Simplify genesis handling #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
==========================================
- Coverage 94.30% 94.29% -0.01%
==========================================
Files 143 143
Lines 16147 16138 -9
==========================================
- Hits 15227 15218 -9
Misses 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
tests/blockchaintest_genesis
branch
from
0975b5d
to
07795ca
Compare
chfast
force-pushed
the
tests/blockchaintest_genesis
branch
from
07795ca
to
9e662a4
Compare
chfast
force-pushed
the
tests/blockchaintest_genesis
branch
from
9e662a4
to
94cd359
Compare
gumb0
reviewed
Jul 23, 2024
gumb0
approved these changes
Jul 23, 2024
Do not execute system contracts on the blockchain test genesis block. It is unspecified how they should behave and the genesis block is expected to be a static block without transactions. Instead just validate there are no transactions/receipt/withdrowals referenced by the genesis block header.
chfast
force-pushed
the
tests/blockchaintest_genesis
branch
from
94cd359
to
d0e72ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not execute system contracts on the blockchain test genesis block. It is unspecified how they should behave and the genesis block is expected to be a static block without transactions.
Instead just validate there are no transactions/receipt/withdrowals referenced by the genesis block header.