precompiles: Implement EIP-2537's bls12_g1add
#982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodiazet
added
precompiles
rodiazet
force-pushed
the
bls-g1-add
branch
2 times, most recently
from
90fcdc7
to
0f5d9b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 94.08% 94.13% +0.04%
==========================================
Files 144 146 +2
Lines 16203 16259 +56
==========================================
+ Hits 15245 15305 +60
+ Misses 958 954 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jwasinger
reviewed
Sep 2, 2024
rodiazet
force-pushed
the
bls-g1-add
branch
5 times, most recently
from
6c3c262
to
9d4a9bc
Compare
chfast
requested changes
Sep 3, 2024
rodiazet
force-pushed
the
bls-g1-add
branch
8 times, most recently
from
8f760fb
to
fc65e10
Compare
chfast
requested changes
Sep 6, 2024
rodiazet
force-pushed
the
bls-g1-add
branch
2 times, most recently
from
f38fc22
to
1fc4803
Compare
chfast
reviewed
Sep 9, 2024
rodiazet
force-pushed
the
bls-g1-add
branch
4 times, most recently
from
90e1735
to
be697a6
Compare
rodiazet
force-pushed
the
bls-g1-add
branch
2 times, most recently
from
0fe96cf
to
fdea4b2
Compare
rodiazet
force-pushed
the
bls-g1-add
branch
from
fdea4b2
to
4d89dfd
Compare
chfast
changed the title
bls12_g1add
rodiazet
force-pushed
the
bls-g1-add
branch
from
4d89dfd
to
60dd68d
Compare
chfast
requested changes
Sep 10, 2024
rodiazet
force-pushed
the
bls-g1-add
branch
from
60dd68d
to
fde4252
Compare
chfast
requested changes
Sep 10, 2024
rodiazet
force-pushed
the
bls-g1-add
branch
4 times, most recently
from
15e7a53
to
7bbddcf
Compare
rodiazet
force-pushed
the
bls-g1-add
branch
from
7bbddcf
to
2ca9a94
Compare
chfast
approved these changes
Sep 10, 2024
rodiazet
added a commit
that referenced
this pull request
Sep 11, 2024
Implementation of the `bls12_g1mul` precompile: E1 affine point's multiplication from BLS12-381 curve by a scalar according to the EIP-2537 spec https://eips.ethereum.org/EIPS/eip-2537#abi-for-g1-multiplication. Depends on #982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
bls12_g1addprecompile: E1 affine points' addition from BLS12-381 curve according to the EIP-2537 spec https://eips.ethereum.org/EIPS/eip-2537#abi-for-g1-addition.Depends on #984