Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Improve blst build on macOS #986

Merged
merged 1 commit into from
Sep 5, 2024
Merged

cmake: Improve blst build on macOS #986

merged 1 commit into from
Sep 5, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 4, 2024

Pass the same C compiler which CMake is using to the blst build script and make sure the compiler's required flags (e.g. -isysroot is also included. Previously we relied on the script to find a C compiler on its own, but this might have not worked.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (6974fd7) to head (bb5704f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         143      143           
  Lines       16142    16142           
=======================================
  Hits        15221    15221           
  Misses        921      921           
Flag Coverage Δ
eof_execution_spec_tests 16.67% <ø> (ø)
ethereum_tests 26.58% <ø> (ø)
ethereum_tests_silkpre 18.68% <ø> (ø)
execution_spec_tests 17.72% <ø> (ø)
unittests 89.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chfast chfast merged commit f2901c8 into master Sep 5, 2024
25 checks passed
@chfast chfast deleted the cmake/blst branch September 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants