Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine API: inform CL with details on validation error #135

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Engine API: inform CL with details on validation error #135

merged 5 commits into from
Nov 30, 2021

Conversation

mkalinin
Copy link
Collaborator

Resolves #120

@lightclient
Copy link
Member

@mkalinin I moved the object definition up into the Structures section, could you let me know if this still looks okay? I was also a bit unsure about what error codes might be returned.

@djrtwo
Copy link
Contributor

djrtwo commented Nov 24, 2021

Does ValidatorError need a version? -- e.g. ValidationErrorV1

@mkalinin
Copy link
Collaborator Author

I have removed ValidationError and instead referenced ErrorObject as it is documented in JSON-RPC spec. Thoughts?

@mkalinin mkalinin force-pushed the engine-api-validation-error branch from 6d07383 to 80a159f Compare November 29, 2021 17:47
@mkalinin
Copy link
Collaborator Author

I have removed ValidationError and instead referenced ErrorObject as it is documented in JSON-RPC spec. Thoughts?

The object is replaced with String|null

lightclient
lightclient approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightclient lightclient merged commit cb8773f into ethereum:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine API: send payload validation error to CL
3 participants
@mkalinin @lightclient @djrtwo