Engine API: adjust error codes with JSON-RPC 2.0 spec #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
approved these changes
May 3, 2022
lightclient
approved these changes
May 4, 2022
There was a problem hiding this comment.
Good catch. I don't think the actual number matters, but as a point of reference I see the LSP spec starts their LSP-specific errors at -32899 and ends it at -32800.
Credits to @MicahZoltu on this finding. If we want to have this spec as a reference, let us have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to JSON-RPC 2.0 spec, the range
[-32768; -32000]is reserved for pre-defined errors. Applications should use values outside of this range.This PR updates existing error codes. It might be a breaking change if a logic of any CL client relies on exact error code value (
-32001).