Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine timeouts (redux) #216

Merged
merged 2 commits into from
May 5, 2022
Merged

engine timeouts (redux) #216

merged 2 commits into from
May 5, 2022

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 4, 2022

(supersedes #207)

  • 8s timeout for engine endpoints with block execution semantics
  • 1s timeout for engine endpoints without execution semantics
  • provide directive that CL MAY call endpoints again that timeout (but they can also move on to other blocks [other chains or descendents).

Likely EL does not abort just because CL does, but EL can/should make the decision on how long to attempt to process (or attempt longer if called again).

@djrtwo djrtwo mentioned this pull request May 4, 2022
Closed
mkalinin
mkalinin approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@djrtwo djrtwo changed the title engine apis (redux) engine timeouts (redux) May 5, 2022
@terencechain terencechain mentioned this pull request May 5, 2022
Merged
@djrtwo djrtwo merged commit 05b5db8 into main May 5, 2022
@djrtwo djrtwo deleted the timeouts-redux branch May 5, 2022 22:03
@tbenr tbenr mentioned this pull request May 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalinin mkalinin mkalinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @mkalinin