oneOf
fails to match when block txs is empty
#243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where
transactions
is an empty array[]
, theoneOf
keyword matches both array items since it can't differentiate. This causes schema validation to fail, becauseoneOf
must match only one of the item subschemas.Two possible fixes:
oneOf
toanyOf
. The subschemas deviate enough that the only time both can match is in the case of an empty array.oneOf
but setminItems
of one of the item schemas to 1. This way, the empty array would only match one item.I went with option 1) because it seems more correct. Under 2), the schema would make the distinction that the empty array is definitely one item type or the other, when in reality there isn't enough information for it to make that conclusion.