Skip to content

Conversation

@fjl
Copy link
Contributor

@fjl fjl commented Jan 3, 2023

This updates the tests from a re-run of the generator, with PR lightclient/rpctestgen#12 applied.

@fjl
Copy link
Contributor Author

fjl commented Jan 3, 2023

There appears to be a unrelated change in the submitted getProof parameters:

https://github.com/ethereum/execution-apis/pull/347/files#diff-01d576c5308c32d1bb61950b4830db13601b4dee9fed8580f4f5616a18f750f7L1-R1

It now submits null as the second parameter. Besu does not accept that.

@fjl
Copy link
Contributor Author

fjl commented Jan 3, 2023

The getProof issue is resolved as of the latest commit.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@lightclient lightclient merged commit 7474e63 into ethereum:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants