Fix json-rpc id to 1 for all tests #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
force-pushed
the
fixed-test-id
branch
from
acee077 to
8006d6c
Compare
lightclient
commented
Jan 10, 2023
| @@ -1,2 +1,2 @@ | |||
| >> {"jsonrpc":"2.0","id":9,"method":"eth_getBalance","params":["0xaa00000000000000000000000000000000000000","0x2ce0e9a8a0b33d45aeb70cf6878d2943deddcf6600e06b84546eaf0a0d2b9643"]} | |||
| << {"jsonrpc":"2.0","id":9,"result":"0x1"} | |||
| >> {"jsonrpc":"2.0","id":1,"method":"eth_getBalance","params":["0xaa00000000000000000000000000000000000000","0x0c5761302ec071b5c04130bf2c8c9167fe8f2efeb756c47d0f44eff683e1203e"]} | |||
There was a problem hiding this comment.
This actually helped me catch the schema error from #326 because it has a leading 0 which isn't allowed for uint, but is for hash32.
|
Also it looks like I have generated some tests in #326 with invalid block hashes. Hivetest2 is failing and regenerating with id == 1 shows a different hash. I believe this PR will resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much easier to read test diffs when the id isn't changing with each fill.