Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert block hash object #351

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Jan 10, 2023

Reverts a change from #326 which turns block hashes into an object. I misunderstood this change and CI did not catch the issue in the tests.

@lightclient lightclient merged commit c539f59 into ethereum:main Jan 10, 2023
@jaypaik
Copy link

jaypaik commented Jan 11, 2023

Just stumbled upon this while looking into https://eips.ethereum.org/EIPS/eip-1898.

I thought I'd add that the EIP explicitly allows for objects that look like: { "blockHash": "0xd4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3", "requireCanonical": false }.

And here's where Geth supports this: https://github.com/ethereum/go-ethereum/blob/452a12aa7903209713ccdc54af65a1a31e73190d/rpc/types.go#L147-L156.

What the EIP does not explicitly specify (at least from my reading of it) is the ability to also pass in block hashes without a wrapper object like above, but it seems that the Geth team allowed this anyway here: https://github.com/ethereum/go-ethereum/blob/452a12aa7903209713ccdc54af65a1a31e73190d/rpc/types.go#L184-L192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants