Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename withdrawal recipient to address #387

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Rename withdrawal recipient to address #387

merged 1 commit into from
Mar 13, 2023

Conversation

lightclient
Copy link
Member

Originally thought this would be clearer than address, but since the CL spec and API does not use recipient it is probably better to conform.

Raised here: ethereum/go-ethereum#26657

@ryanschneider ryanschneider mentioned this pull request Mar 9, 2023
Closed
@ryanschneider
Copy link
Contributor

✅ BTW this closes #378

siladu
siladu approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - besu uses address

@lightclient lightclient merged commit d01e55d into ethereum:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lightclient @ryanschneider @siladu @smartprogrammer93