graphql: specify Long input and output formats #389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR After this PR every number field will be hex-formatted. Numeric inputs are flexible and can be provided as number or string.
The spec is vague in defining which inputs are accepted for
Long
and how outputs are formatted. I suggest thatLong
behave similar toBigInt
s in this sense. I.e. be flexible when taking input, but output hex-encoded values. My reasoning is that:Every field with type
Int
has been changed to be aLong
for consistency.Hive tests: ethereum/hive#746