Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for debug methods #464

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

alexandratran
Copy link
Contributor

Add examples for:

  • debug_getBadBlocks
  • debug_getRawBlock
  • debug_getRawHeader
  • debug_getRawReceipts
  • debug_getRawTransaction

The examples are taken from the Besu API docs.

This will be the first in a series of PRs adding examples to this OpenRPC spec.

@mkalinin
Copy link
Collaborator

@alexandratran could you please rebase this PR to main?

@alexandratran
Copy link
Contributor Author

@mkalinin done

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGTM!

@alexandratran
Copy link
Contributor Author

@mkalinin No problem! (Again, can you merge since I don't have write access?)

@lightclient
Copy link
Member

lightclient commented Sep 15, 2023

This PR looks correct, but do you have a way to verify it displays correctly? The openrpc playground doesn't appear to support method examples right now.

--

update: I see the engine examples are working on the deployed version, for some reason my local one wasn't showing it

@lightclient lightclient merged commit 5849052 into ethereum:main Sep 15, 2023
3 checks passed
@alexandratran alexandratran deleted the add-examples branch September 15, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants