-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eth_blobBaseFee; add blobs to eth_feeHistory #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! The changes to eth_feeHistory
look good, but I'm not sure about the new method eth_gasPrices
.
Another thought on |
is there a better way of calculating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it yaml?
Let's start with simpler approach and see how convenient may be to have just that separate method for now. |
Do you mean json might work better? |
base fee of parent * small multiple like 1.25 + result of |
lgtm! I asked on Discord but does the rename to "blob base fee" in ethereum/EIPs#8095 mean we need to update any other 4844 RPC field names (e.g. |
Curious what are the next steps for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ratio of blobGasUsed
and the limit for blobs isn't defined in the api currently, but we can use same naming as the EIP which is "max blob gas per block".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both APIs look good, we should be able to support eth_blobBaseFee
easily and already support the additional blob fields in feeHistory
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
looks good! |
I know this has been merged already, but I wonder why this method doesn't accept a block tag? |
Blob gas price oracle and historical API
Makes sending blob more convenient. Notes and prototype
Add eth_blobBaseFee
A new method that returns blob gas price prediction
Update for eth_feeHistory
Add two fields related to blob gas