-
Notifications
You must be signed in to change notification settings - Fork 409
Add error when accessing pruned chain data #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, LGTM
It should be the same for |
There is an open question on eth_getLogs: if the range goes beyond the cutoff point, do we return an error or only return logs for post-cutoff point? I am thinking the latter but want to raise it in case others disagree. |
We think it should be like this: if the starting point of a |
This adds an error in the RPC when a users requests data that has been pruned.
Affected RPC:
It would be better to create a reusable error for this, but that will require reorganzing the project structure, updating the build pipeline, and resolving the site generation issues. I started working on this here, but wasn't able to get the site generator working. We need to just move to docausauraus.