Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace flake8, flake8-spellcheck, isort and black with ruff and codespell #811

Open
danceratopz opened this issue Sep 16, 2024 · 6 comments
Assignees
Labels
scope:tooling Scope: Python tools (uv, ruff, tox,...) type:chore Type: Chore

Comments

@danceratopz
Copy link
Member

danceratopz commented Sep 16, 2024

Replace flake8, flake8-spellcheck, isort and black with ruff and codespell. Motivation: ruff is insanely fast. For the conversion, it won't be possible to maintain both systems side-by-side, as there are known deviations from black.

This will touch a few source files, but shouldn't be too drastic (like #137).

@danceratopz danceratopz added type:chore Type: Chore scope:tooling Scope: Python tools (uv, ruff, tox,...) labels Sep 16, 2024
@danceratopz danceratopz changed the title chore: flake8, flake8-spellcheck, mypy and black with ruff chore: flake8, flake8-spellcheck, isort and black with ruff Sep 16, 2024
@danceratopz danceratopz changed the title chore: flake8, flake8-spellcheck, isort and black with ruff chore: flake8, flake8-spellcheck, isort and black with ruff and codespell Sep 16, 2024
@danceratopz danceratopz changed the title chore: flake8, flake8-spellcheck, isort and black with ruff and codespell chore: replace flake8, flake8-spellcheck, isort and black with ruff and codespell Sep 16, 2024
@danceratopz
Copy link
Member Author

This will greatly simplify things (not a fan of this doc page!):
image

@raxhvl
Copy link
Contributor

raxhvl commented Sep 26, 2024

on it!

@danceratopz
Copy link
Member Author

Thanks @raxhvl, appreciate it, but @spencer-tb's actively working on this at the mo.

Feel free to reach out if there's something else you'd particularly like to work on https://ethereum.github.io/execution-spec-tests/main/getting_help/.

@raxhvl
Copy link
Contributor

raxhvl commented Sep 26, 2024

Thanks for the quick heads up. I'll discuss on discord.

@raxhvl
Copy link
Contributor

raxhvl commented Sep 26, 2024

Quick note - do the docs says #testing in Eth R&D but i think it should be #el-testing?

@danceratopz
Copy link
Member Author

Quick note - do the docs says #testing in Eth R&D but i think it should be #el-testing?

Oh yeah, that's right, the discord got updated. Thanks! I can take that one to save you opening a PR just for that 🙂 I have a few misc improvements i need to make.

Also feel free to DM on discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tooling Scope: Python tools (uv, ruff, tox,...) type:chore Type: Chore
Projects
None yet
Development

No branches or pull requests

3 participants