-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): add ruff
as default linter and additional clean up
#922
Draft
spencer-tb
wants to merge
9
commits into
main
Choose a base branch
from
dog-goes-ruffruffruff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
changed the title
feat(all
feat(all): add Oct 29, 2024
ruff
as the default linter for EEST
spencer-tb
changed the title
feat(all): add
feat(all): add Oct 29, 2024
ruff
as the default linter for EESTruff
as default linter and additional clean up
spencer-tb
force-pushed
the
dog-goes-ruffruffruff
branch
3 times, most recently
from
October 30, 2024 08:26
53288a9
to
cfd6b11
Compare
spencer-tb
force-pushed
the
dog-goes-ruffruffruff
branch
from
October 30, 2024 08:43
cfd6b11
to
e057231
Compare
spencer-tb
force-pushed
the
dog-goes-ruffruffruff
branch
from
October 30, 2024 09:29
b3f6ae4
to
5e61b48
Compare
@spencer-tb could we rebase this to main please? I think it would make it easier to spot issues in the CI if we include the fixes from #905 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Description
Pre-dominantly adds
ruff
as our default linter to replaceflake8
,black
&isort
. Extra clean-up items are mentioned below.π§βπ»
.vscode
The
settings.recommended.json
has be split into 2 files:settings.json
: locked config that users of the repo MUST use..settings.local.recommended.json
: settings that users can change, for example python testing extension related.π₯ Removal of
tf
It seems relevant for us to deperate
tf
now. Most repo users are familiar with theuv fill
etc approach now.π Ruff Related Docstring Changes
A large portion of the diff comes from changes to the python docstrings, via:
β Fixes to
noqa:
andTODO:
Those that can be fixed now are updated!
With a new linter its seems logical to enforce python docstring standards from now on. Note the warnings appear within VSCode and additionally when running tox.
π Related Issues
#811
β Checklist