fix(ethereum_clis): Retry on connection error in _evaluate_server() for EELS daemon
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
reviewed
Oct 23, 2024
marioevz
reviewed
Oct 30, 2024
marioevz
changed the title
start_server() for EELS daemon_evaluate_server() for EELS daemon
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
There appears to be a brief delay between the Unix socket file being created and connections being accepted on the socket. This may be the cause of sporadic CI failures with the EELS daemon.
This PR adds a check to
start_server()to see if the EELS daemon has actually started accepting connections.🔗 Related Issues
Resolves #852
✅ Checklist