Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): EIP-7702: Spec update #9248 #1129

Merged
merged 3 commits into from
Jan 30, 2025
Merged

fix(tests): EIP-7702: Spec update #9248 #1129

merged 3 commits into from
Jan 30, 2025
+44 −32

Conversation

marioevz
Copy link
Member

🗒️ Description

Updates EIP-7702 tests to match spec update implemented in ethereum/EIPs#9248

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Jan 24, 2025
@marioevz
Copy link
Member Author

Filled using this temporary branch: https://github.com/marioevz/execution-specs/tree/eip-7702-ext-update

@danceratopz
Copy link
Member

See also:

@marioevz marioevz mentioned this pull request Jan 22, 2025
Open
10 tasks
@danceratopz danceratopz added the fork:prague Prague hardfork label Jan 30, 2025
@marioevz marioevz requested a review from winsvega January 30, 2025 15:42
winsvega
winsvega approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Haven't got the time to read the spec

@marioevz marioevz merged commit 9b84e40 into main Jan 30, 2025
21 checks passed
@marioevz marioevz deleted the eip-7702-9248-spec-update branch January 30, 2025 16:14
marioevz added a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
@marioevz
fix(tests): EIP-7702: Spec update #9248 (ethereum#1129)
2de9ab7 
* fix(tests): EIP-7702: Spec update #9248

* docs: CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marioevz @danceratopz @winsvega