Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): fix unit tests and use Bytecode verbatim #1137

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(tests): fix unit tests and use Bytecode verbatim #1137

merged 1 commit into from
Jan 28, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 28, 2025 •
edited by danceratopz
Loading

🗒️ Description

The #1119 had incorrect unit test. This fixes the unit tests and uses the verbatim bytes in tests added in the mean time.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.

@chfast chfast requested review from pdobacz and marioevz January 28, 2025 09:18
danceratopz
danceratopz approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes scope:fw Scope: Framework (evm|tools|forks|pytest) labels Jan 28, 2025
@danceratopz danceratopz merged commit fd62bd3 into ethereum:main Jan 28, 2025
11 checks passed
@danceratopz danceratopz deleted the bytecode-verbatim branch January 28, 2025 09:26
@danceratopz danceratopz mentioned this pull request Jan 28, 2025
Merged
8 tasks
marioevz pushed a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
@chfast @marioevz
fix(tests): fix unit tests and use Bytecode verbatim (ethereum#1137)
40b5462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danceratopz danceratopz danceratopz approved these changes

@pdobacz pdobacz Awaiting requested review from pdobacz

@marioevz marioevz Awaiting requested review from marioevz

Assignees
No one assigned
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @danceratopz