fillers/eips/eip3860: Update EIP-3860 Due to Spec Change #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
requested changes
Jan 13, 2023
marioevz
approved these changes
Jan 13, 2023
danceratopz
referenced
this pull request
in danceratopz/execution-spec-tests
Jan 18, 2023
* Small change for EIP-3860 spec change. * Small change for EIP-3860 spec change and fix for salt change. * Tox fix. * Add additional OOG error catching. * Fix initcode contract data copy. * Merge conflicts. * fillers/eips: add salt to create2 contract creation (#20) * fillers/eips: add salt to create2 contract creation (#20) * SSTORE a value regardless of what CALL returns for further validation. * Apply suggestions from code review Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there is an initcode length violation for 'CREATE'/'CREATE2' the gas for the initcode execution is not deducted but stored. In the new spec change here -> ethereum/EIPs#6249 the evm exceptionally aborts as if it runs out of gas. A small fix is added to achieve the latter.