fillers/withdrawals/withdrawals: Update to use Gwei instead of Wei. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
requested changes
Jan 17, 2023
|
I think some of the tests are failing because of the issue described in my review. The up-to-date go-ethereum branch with gwei withdrawals is https://github.com/lightclient/go-ethereum/tree/withdrawals-timestamp, so I think we can use this branch to double check that the changes are correct. |
marioevz
reviewed
Jan 17, 2023
marioevz
approved these changes
Jan 17, 2023
danceratopz
pushed a commit
to danceratopz/execution-spec-tests
that referenced
this pull request
Jan 18, 2023
…thereum#32) * Update withdrawals to use gwei. * Tox fix and flake8 SC200 ignore. * Keep factors consistent when changing to GWEI. * Re-update due to conversion mistake. * Another tox update :P * Add max withdrawal amount to zero amount test. * Add gwei/wei to whitelist for tox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #30.