feat(transition_tool): Use execution-specs daemon #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
scope:evm
danceratopz
requested changes
Feb 28, 2024
| @@ -27,6 +27,7 @@ install_requires = | |||
| setuptools | |||
| types-setuptools | |||
| requests>=2.31.0 | |||
| parsys-requests-unixsocket==0.3.1 | |||
There was a problem hiding this comment.
Any reason for the strict version pinning?
There was a problem hiding this comment.
Didn't really think about it when adding it, should it be >=0.3.1?
| chain_id: int = 1, | ||
| reward: int = 0, | ||
| eips: Optional[List[int]] = None, | ||
| debug_output_path: str = "", |
There was a problem hiding this comment.
We still need to add --evm-dump-dir support.
Co-authored-by: danceratopz <danceratopz@gmail.com>
10 tasks
4 tasks
|
Closing in favour of #792! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Implements usage of the execution-specs evm daemon implemented in this branch: https://github.com/ethereum/execution-specs/tree/evm-daemon
Which makes filling all tests with EELS around 57 times faster.
I've also diff'd the resulting fixtures and the only difference in all of them is the evm version in the
_info.To test the deamon with this branch in an existing/installed execution-spec-tests setup:
pip uninstall ethereum pip install ethereum@git+https://github.com/ethereum/execution-specs@evm-daemon # verify daemon option is available in `ethereum-spec-evm`'s help: ethereum-spec-evm --help fill --evm-bin=ethereum-spec-evm🔗 Related Issues
None.
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.