Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EIP-3540: extcode semantics on EOF init container mid-creation #601

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 6, 2024

πŸ—’οΈ Description

Adds a test to verify the behavior of EXTCODESIZE, EXTCODECOPY and EXTCODEHASH when the target is an EOF container in the middle of creation.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the scope:tests Scope: Test cases label Jun 6, 2024
@marioevz marioevz requested a review from shemnon June 6, 2024 19:10
@marioevz marioevz force-pushed the eof/3540-extcode-initcontainer branch from 832ecec to 93cd82e Compare June 6, 2024 19:11
@marioevz
Copy link
Member Author

marioevz commented Jun 6, 2024

I'm getting empty contract results from all EXTCODE* opcodes when called to a EOF container mid-creation, which I guess makes sense because the container is not there yet so technically it should still return empty.

Maybe only this should be explicitly specified? @shemnon @chfast @gumb0

@marioevz marioevz force-pushed the eof/3540-extcode-initcontainer branch from 93cd82e to 01125db Compare June 7, 2024 17:04
@marioevz marioevz changed the title new(tests): EIP-3540: extcode semantics on EOF init container mid-execution new(tests): EIP-3540: extcode semantics on EOF init container mid-creation Jun 10, 2024
@marioevz marioevz force-pushed the eof/3540-extcode-initcontainer branch from 8b34ae0 to 56ba778 Compare June 20, 2024 16:57
@marioevz marioevz force-pushed the eof/3540-extcode-initcontainer branch from 56ba778 to 346b402 Compare June 20, 2024 17:02
@marioevz
Copy link
Member Author

To be merged using "Rebase and merge" and preserve the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant