Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture Format: Append withdrawals list to the end of genesisRLP for >= Shanghai #80

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Fixture Format: Append withdrawals list to the end of genesisRLP for >= Shanghai #80

merged 3 commits into from
Mar 17, 2023

Conversation

spencer-tb
Copy link
Collaborator

This PR addresses the following issues: #76 and #64, where it certain fixture test cases were found to be missing withdrawals in their genesisRLP. The withdrawals list will now be appended to the end of the genesisRLP for all test cases >= Shanghai.

#Before: `many_withdrawals.json`
"genesisRLP": "0xf9021...363b421c0c0",
#Now:
"genesisRLP": "0xf9021...363b421c0c0c0",

A small refactor of specific functions within state_test and blockchain_test are added to help spot similar issues more quickly in the future.

marioevz
marioevz approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks!

@marioevz marioevz merged commit b244137 into ethereum:main Mar 17, 2023
@spencer-tb spencer-tb deleted the add-withdrawals-to-genesis-rlp branch April 7, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencer-tb @marioevz