Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): change image from ubuntu-24.04 to ubuntu-latest #855

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Oct 1, 2024

🗒️ Description

#792 changed the images used from ubuntu-latest to ubuntu-24.04 (latest pointed to ubuntu-22.04 at the time). This PR reverts this change as latest has been bumped to ubuntu-24.04 in Github Actions in actions/runner-images@ae99c16.

Using ubuntu-latest simplified the need to use -P to map the image correctly. The following is from the never published and now defunct docs:

"Specifying the `ubuntu-24.04` docker image"

    [#792](https://github.com/ethereum/execution-spec-tests/pull/792/) made EELS the default `t8n` tool. Our Github workflows were changed to use the `ubuntu-24.04` docker image which has OpenSSL 3.0.7, required by EELs to have RIPEMD160 support (used by the precompile at `0x03`). As of 2024-09-30 `ubuntu-latest` resolves to `ubuntu-22-04`.

    To run workflows that use `ubuntu-24.04` with `act` (as of version 0.2.67) the following must be added to the command-line:

    ```bash
    -P ubuntu-24.04=ghcr.io/catthehacker/ubuntu:full-24.04
    ```

🔗 Related Issues

#792

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added scope:ci Scope: Continuous Integration type:chore Type: Chore labels Oct 1, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 1675bda into main Oct 1, 2024
5 checks passed
@marioevz marioevz deleted the chore/ci/use-ubuntu-latest branch October 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants