Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): Blockhash at 255/256/257 (ethereum/execution-specs#374) #988

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codeofcarson
Copy link

🗒️ Description

This adds tests designed to test the BLOCKHASH opcode for when there are 255, 256, and 257 blocks in the chain.

Filled with https://github.com/ethereum/execution-specs#9b95554a88d2a8485f8180254d0f6a493a593fda

🔗 Related Issues

This is actually issue (ethereum/execution-specs#374) in the execution-specs

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

I will add the CHANGELOG update before this gets merged after review.

Do I need to update the docs in the codebase for this one too?

@codeofcarson codeofcarson marked this pull request as draft December 3, 2024 20:38
@codeofcarson
Copy link
Author

For this one I sneakily grabbed the hashes off of the outputs for the tests when I ran them. You won't be able to do that with future forks right? Is there a way that it could be computed on the fly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant