Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Nov 3, 2025

🗒️ Description

We've since moved the testing framework package to dev dependencies which are installed by default with a uv sync. This PR removes the old install extra call for test which no longer exists.

This was tested already in the latest bal release here. Previous fail without this change here.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2025-11-03 at 11 25 45

@fselmo fselmo added C-bug Category: this is a bug, deviation, or other problem A-test-tools Area: execution spec tests tooling labels Nov 3, 2025
@fselmo fselmo marked this pull request as ready for review November 3, 2025 18:26
@fselmo fselmo requested a review from marioevz November 3, 2025 18:26
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@spencer-tb spencer-tb merged commit 9674b7a into ethereum:forks/osaka Nov 3, 2025
8 of 9 checks passed
@fselmo fselmo deleted the fix/fix-uv-sync-on-fixture-releases branch November 3, 2025 19:51
@danceratopz
Copy link
Member

Thanks for this! Sorry that this got missed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tools Area: execution spec tests tooling C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants