Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-1153 to CFI for Shanghai #642

Conversation

holgerd77
Copy link
Contributor

PR adds EIP-1153 as a CFI EIP for Shanghai (ACD #149).

Updated table should render correctly:

grafik

@moodysalem
Copy link
Contributor

moodysalem commented Nov 11, 2022

Thanks for sending this PR, there are a bunch of links to add. Project board is here if it's worth linking to.

Here are the implementations:
Geth: ethereum/go-ethereum#26003 (Not merged)
Besu: hyperledger/besu#4118 (Not merged)
Nethermind: NethermindEth/nethermind#4126 (Merged)
EthereumJS: ethereumjs/ethereumjs-monorepo#1860 (Merged)

AFAIK Erigon is not started yet, though I heard they will borrow heavily from geth

@holgerd77
Copy link
Contributor Author

Thanks for sending this PR, there are a bunch of links to add. Project board is here if it's worth linking to.

Here are the implementations: Geth: ethereum/go-ethereum#26003 (Not merged) Besu: hyperledger/besu#4118 (Not merged) Nethermind: NethermindEth/nethermind#4126 (Merged) EthereumJS: ethereumjs/ethereumjs-monorepo#1860 (Merged)

AFAIK Erigon is not started yet, though I heard they will borrow heavily from geth

Thanks, have updated in c5b6981.

Have also added some missing EthereumJS implementation status updates in 3b47ab1.

@moodysalem
Copy link
Contributor

Is there something we can do to get the failed tests to pass?

@timbeiko timbeiko merged commit d703ef0 into ethereum:master Nov 14, 2022
@timbeiko
Copy link
Collaborator

@moodysalem I forced-merged this because these handful of .md files are a bit weird wrt to the rest of the repo (which is an actual spec). Eventually it might make sense to clean this up / move them out, but for now, it's all sort of bundled together 😅 !

@tynes tynes mentioned this pull request Nov 14, 2022
@holgerd77 holgerd77 deleted the add-eip-1153-transient-storage-to-shanghai-cfi branch November 15, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants