Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOF EIPs to Cancun CFI List #688

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Add EOF EIPs to Cancun CFI List #688

merged 1 commit into from
Jan 23, 2023

Conversation

timbeiko
Copy link
Contributor

Decided on ACDE153

@holgerd77
Copy link
Contributor

holgerd77 commented Jan 23, 2023

Would it be worth to add the client readiness table from ad2bd93 (not 100% sure this is the correct commit to pick from) so that it won't get forgotten (this was some substantial work to put this together I guess)? 🤔 I would assume this will stay relatively static over time.

@timbeiko
Copy link
Contributor Author

timbeiko commented Jan 23, 2023

@holgerd77 I'm not a huge fan of the CFI table & it's something we sort of started to do only for Shanghai. IMO they make more sense for Included EIPs. Given we're still pretty early in the Cancun planning, an we may see non-trivial EOF spec changes, I'd hold off for now. At the very least, I think it should be a separate PR.

@timbeiko timbeiko merged commit e5044cd into master Jan 23, 2023
@holgerd77
Copy link
Contributor

@holgerd77 I'm not a huge fan of the CFI table & it's something we sort of started to do only for Shanghai. IMO they make more sense for Included EIPs. Given we're still pretty early in the Cancun planning, an we may see non-trivial EOF spec changes, I'd hold off for now. At the very least, I think it should be a separate PR.

Sure, makes sense. 👍

@jakerockland
Copy link

@timbeiko which EOF EIPs is this? Is it all of: EIP-3540, EIP-3670, EIP-4200, EIP-4750, and EIP-5450?

@SamWilsn SamWilsn deleted the timbeiko-patch-12 branch April 10, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants