Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Goerli Fork Epoch #724

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Add Goerli Fork Epoch #724

merged 4 commits into from
Mar 3, 2023

Conversation

timbeiko
Copy link
Collaborator

@timbeiko timbeiko commented Mar 2, 2023

Epoch 162304 decided on ethereum/pm#729, ETA: 3/14/2023, 10:25:36 PM UTC

siladu

This comment was marked as outdated.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamp is wrong I think

network-upgrades/mainnet-upgrades/shanghai.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fb58e3c) 71.89% compared to head (39feff6) 71.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files         570      570           
  Lines       31570    31570           
=======================================
  Hits        22696    22696           
  Misses       8874     8874           
Flag Coverage Δ
unittests 71.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Simon Dudley <simon.l.dudley@hotmail.com>
@timbeiko
Copy link
Collaborator Author

timbeiko commented Mar 2, 2023

@siladu you're right - timezone was off in my original one. Confirming yours is correct:
Screenshot 2023-03-02 at 12 01 36 PM

@timbeiko timbeiko merged commit 865c470 into master Mar 3, 2023
q9f pushed a commit to eth-clients/goerli that referenced this pull request Mar 6, 2023
* Add Shapella fork times

Signed-off-by: Tim Beiko <t.beiko23@gmail.com>

* Update timestamp

See: ethereum/execution-specs#724 (comment)

* Update config.yaml

---------

Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
finiteops pushed a commit to bitfinity-network/erigon that referenced this pull request Apr 10, 2023
@SamWilsn SamWilsn deleted the shanghai-goerli-fork branch April 10, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants