Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ensure with if-statements #932

Merged
merged 14 commits into from
May 7, 2024
Merged

Conversation

SamWilsn
Copy link
Collaborator

What was wrong?

Related to Issue #588

How was it fixed?

https://gist.github.com/SamWilsn/f91192bf4f3988aa5150d5e5d248c2c3

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn SamWilsn force-pushed the ensure branch 2 times, most recently from f43ae95 to 4b54b29 Compare April 19, 2024 01:06
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 586 lines in your changes are missing coverage. Please review.

Project coverage is 74.28%. Comparing base (f5a3b89) to head (a91977d).
Report is 64 commits behind head on master.

Files Patch % Lines
src/ethereum/arrow_glacier/fork.py 0.00% 72 Missing ⚠️
src/ethereum/gray_glacier/fork.py 0.00% 72 Missing ⚠️
src/ethereum/dao_fork/fork.py 0.00% 64 Missing ⚠️
src/ethereum/muir_glacier/fork.py 0.00% 62 Missing ⚠️
src/ethereum/paris/fork.py 48.14% 28 Missing ⚠️
src/ethereum/rlp.py 73.68% 15 Missing ⚠️
src/ethereum/constantinople/fork.py 80.64% 12 Missing ⚠️
src/ethereum/byzantium/fork.py 82.25% 11 Missing ⚠️
src/ethereum/frontier/fork.py 82.25% 11 Missing ⚠️
src/ethereum/homestead/fork.py 82.25% 11 Missing ⚠️
... and 79 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   74.26%   74.28%   +0.02%     
==========================================
  Files         602      643      +41     
  Lines       32670    35932    +3262     
==========================================
+ Hits        24261    26693    +2432     
- Misses       8409     9239     +830     
Flag Coverage Δ
unittests 74.28% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamWilsn SamWilsn merged commit 0f116b5 into ethereum:master May 7, 2024
5 checks passed
@SamWilsn SamWilsn deleted the ensure branch May 7, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants