Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown & RLP #968

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Markdown & RLP #968

merged 5 commits into from
Aug 13, 2024

Conversation

SamWilsn
Copy link
Collaborator

@SamWilsn SamWilsn commented Jun 21, 2024

Open Questions / Tasks

  • What are better names for rlp.Serialize and rlp.Deserialize? I was thinking rlp.Complex and rlp.Simple respectively.
  • Remove uses of cast (e.g. here)

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Collaborator

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Found one issue.

src/ethereum/frontier/transactions.py Outdated Show resolved Hide resolved
@petertdavies petertdavies merged commit fcd1275 into ethereum:master Aug 13, 2024
5 checks passed
SamWilsn added a commit that referenced this pull request Aug 13, 2024
@SamWilsn SamWilsn deleted the markdown branch August 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants