stuff to figure out

ethereum · Jul 2, 2021 · cb6eab6 · cb6eab6
1 parent a2d0a06
commit cb6eab6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/crates/test-files/fixtures/solidity/revert_test.sol b/crates/test-files/fixtures/solidity/revert_test.sol
@@ -12,6 +12,12 @@ struct Bag {
 
 error StructError(Bag data);
 
+struct StringBag {
+  string val0;
+}
+
+error StringBagError(StringBag data);
+
 contract Foo {
 
   function revert_me() public pure {
@@ -50,4 +56,8 @@ contract Foo {
     revert StructError(Bag ({ val1: 100, val2: -100, val3: true }));
   }
 
+  function revert_with_stringbag_error() public pure {
+    revert StringBagError(StringBag ({ val0:"foo" }));
+  }
+
 }
diff --git a/crates/tests/src/solidity.rs b/crates/tests/src/solidity.rs
@@ -39,6 +39,11 @@ use fe_compiler_test_utils::*;
         "revert_with_struct_error",
         encode_error("StructError((uint256,int256,bool))", &[uint_token(100), int_token(-100), bool_token(true)])
     ),
+    // The tuple itself adds another offset but only if the tuple contains a string? 🤔
+    // case(
+    //     "revert_with_stringbag_error",
+    //     encode_error("StringBagError((string))", &[string_token("foo")])
+    // ),
 )]
 fn test_revert_errors(method: &str, reason: Vec<u8>) {
     with_executor(&|mut executor| {