Windows compilation fails: "ethutil\script_windows.go:12: Compile redeclared in this block"

[erezwanderman]

Full output:

$ go install -v
github.com/ethereum/go-ethereum/ethutil
# github.com/ethereum/go-ethereum/ethutil
C:\Ethereum\go\src\github.com\ethereum\go-ethereum\ethutil\script_windows.go:12: Compile redeclared in this block
        previous declaration at C:\Ethereum\go\src\github.com\ethereum\go-ethereum\ethutil\script_unix.go:13
gopkg.in/qml.v1/cdata
gopkg.in/qml.v1/gl/glbase
gopkg.in/qml.v1
github.com/howeyc/fsnotify

"_unix" is NOT a valid go build constraint. Therefore go tries to compile both "script_unix.go" and "script_windows" on Windows. And function "Compile" is redefined.

[fjl]

I don't have windows and can't test the fix, but it should work.

[obscuren]

Strange *_unix.go should be any *nix type OS (e.g., Linux, BSD, OS X). Prior to that naming scheme it had the "ugly" magic comment @fjl 's fix has.

[erezwanderman]

I don't see _unix.go mentioned in the documentation of build constraints http://golang.org/pkg/go/build/
The list seems to be here: https://golang.org/src/pkg/go/build/syslist.go

[obscuren]

Odd, perhaps it was wishful thinking :-)

[obscuren]

Old and fixed