Why does the enode nodeId information not support the domain name?

[zjsunzone]

Hi there,

please note that this is an issue tracker reserved for bug reports and feature requests.

For general questions please use the gitter channel or the Ethereum stack exchange at https://ethereum.stackexchange.com.

System information

Geth version: geth version
OS & Version: Windows/Linux/OSX
Commit hash : (if develop)

Expected behaviour

Actual behaviour

Steps to reproduce the behaviour

Backtrace

[backtrace]

[FrankSzendzielarz]

The main reason is privacy.
Other reasons might include DNS attack vectors.
https://ethereum.stackexchange.com/questions/37445/is-it-possible-to-use-domain-names-in-place-of-ip-addresses-for-peer-nodes-stat

[easeev]

Guys @karalabe @FrankSzendzielarz @fjl,

1. Could you please elaborate on how IP is more private than a domain name? Both are just plaintext identifiers.
2. Is it really that hard to add hostname resolution to IP similar to what Parity does? Will be very helpful to operate Geth nodes in modern environments (e.g. cloud).

[karalabe]

1. It's not more private. It's more secure, because taking over an IP is a lot harder than a domain. That said, as long as the public key is mandatory, I don't see too big of a danger. 2. No, it's 1 line of code.

…

On Wed, Aug 14, 2019, 15:22 Eugene Aseev ***@***.***> wrote: Guys @karalabe <https://github.com/karalabe> @FrankSzendzielarz <https://github.com/FrankSzendzielarz> @fjl <https://github.com/fjl>, 1. Could you please elaborate on how IP is more private than a domain name? Both are just plaintext identifiers. 2. Is it really that hard to add hostname resolution to IP similar to what Parity does <https://github.com/paritytech/parity-ethereum/blob/master/parity/helpers.rs#L185>? Will be very helpful to operate Geth nodes in modern environments (e.g. cloud). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18340?email_source=notifications&email_token=AAA7UGP5SZJHI2DA6EJC233QEP2JRA5CNFSM4GLNN2X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IT3TA#issuecomment-521223628>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA7UGJJFMA6JELC4B6LB5DQEP2JRANCNFSM4GLNN2XQ> .

[easeev]

Thanks @karalabe!

Could you review and merge #18524 then?