No pending block in reply of eth_getBlockByNumber

[temandroid]

System information

Geth version: 1.9.10-stable
OS & Version: Ubuntu 18.04.3 LTS
Commit hash : 58cf568

Actual behaviour

Reply of pending block in eth_getBlockByNumber is null (number:null) but must be blocknumber

Steps to reproduce the behaviour

curl --data '{"method":"eth_getBlockByNumber","params":["pending", false],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST http://localhost:8545

Backtrace

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "difficulty": "0x747ba36f84598",
    "extraData": "0x4d696e6564206279206574682e6963616e6d696e696e672e7275",
    "gasLimit": "0x961500",
    "gasUsed": "0x7cc1fb",
    "hash": null,
    "logsBloom": "0x494b02088106ac2049c0158130020004c8f007b1a41d1141002014c52b7a20b84518d76102842b403141c4270baa0110110198c013033605404dcb9220a8f040400a08cd068089911820860aa088d1c2a09380362a080269013a221088000430184010201284e00d21296a0101441800044802220806491c04140d9a7d32a39022c0d0a50e81840804a0030b0169cc02288dedd123020866004301d840122808044426248016600a0e08c2a8009ac280c00c1102a2a08a01fc40844099ad13571011800260842030e41e842281a28034946042049028024a8d50a44851d16a0a0602a40fb0842a098b0041140420b3540ca12318b4d3dc4418083804881428d0",
    "miner": null,
    "mixHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "nonce": null,
    "number": null,
    "parentHash": "0x327719b458156eaefcf2cb5d9b4c47e8508d5a8dd45bde576e3237fd1bee1be0",
    "receiptsRoot": "0xc1c76b1e0ff5cf3611c2652e548f0d91356208b3c94c3e9caa0c351ef0a1e7ce",
    "sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
    "size": "0x7669",
    "stateRoot": "0x38b31dafe124bc4a0cd8b359d4c44d9728d77cf272813928d8892ba6c4c1879a",
    "timestamp": "0x5e280833",
    "totalDifficulty": null,
    "transactions": [
      "0xbc7a253b2cef00bfbf3a5db8f2c08d6c718871200981ba5783bb7ca6dbc9bfb0",
      "0xffadeba7e3e548414c2da4080e58577fc67378467911eac308149b0767ddc820",
      "0x8423fea1cba42427d6bfa8e8207a8c7b86f3ab35d8b39268e499ba4446572a68",
      "0xc61bbe2d9cb4f5d2737935c4d0e846655633c7f8ad85397c8685d503e8c1c1f3",
      "0x6b4114f47f97e51fb17fe45a342061de72ea692273fdbabf38fac039cd2fd50b",
      "0x48bd982f52415e5999b244d3a0e3bac6c809e49f40b4e2f2db9560049bd941fe",
      "0x9068de54c622306d7b2118b6d7edb7aa9b5c46df8f53fa073cda0f1a49419c45",
      "0x47c707053b04938423cb942b5d84d9a91aa272fcd2a76640af81a71984a08eb5",
      "0xefadcac5f903c64a81cf6943f1044e8f0aacdbb42f0dbf5f21dc2bce353d8815",
      "0x3ad9fa2225f2998314204889fcd1b13eb8bda04a6dd6ec3a7b09ce3ca2083dc8",
      "0x03c44c65a18d441303d2f4ff5bfaf62c6989546e115a49e36f251c54c6a37a08",
      "0x0051e4d500953d6640d79990f57ee0910d64bd2561ee1ca5f9865a3a70104849",
      "0xf37aaae4545a342587875eeb7d13e18c1a2ca57fa78d5ccd023b21c2beed03ec",
      "0x15490de3087bc3eadf861210044268928fc8063bd5fe81c5d9ea7d224d1145b3",
      "0x5fb935faa6e10c108ef4952ef9354dc35deddd54961337d2a63c0869e66190af",
      "0xeeae151168595a5ac29297679ed41532c0315738fa34517df39287d93bb9ee57",
      "0x21790c5be23be3bd5a18f68f2e34d64007cf0f2c57438f1adebe7598060183d2",
      "0x9f15b447d988a3d654a3914e5bb3f4da5cadc77937aaadf4d298e2e0d3df4ef0",
      "0x6832ee1dea2e438a99569471c6543ba98fe0689ef5f05a094b381ce7314f1438",
      "0x95012dc94264dc299df356c72039c22fdac8683e8b7c70bfa1681ef7b9bc8b82",
      "0x3aa11d3abadd71276532093a5c24530c89c802fa5c8f1b74d6d39cd837a7245d",
      "0x35ce2946a9b17309928b0401222fff5ed581de990561fed84dd51c9def607d4b",
      "0x9aefa5d758bbda6e2ea05ed7433b8ad5ef7608e8799b95f1517d90a7bd23b445",
      "0x7fe90ebedb2e0fe5a94beb4290cfddb7b33c017b9706c9c96f6ae54ba9eb72a4",
      "0xb5bd530fcce3f49b5109b8d3b546ebbc22992f056f3ef978900ce7e0d3192f2b",
      "0x9e45e7703d782d335f8c6a549adca9f5a547d0b0ea8c795d80c351574ed97635",
      "0xc14f63342ccb3c75294ca42a8af346986ac382dc88ffa51d0280ea9a69798cdf",
      "0x72853719e5fb96c40f2682570df05b46a1118a23dc2166b1e1acde0925f39668",
      "0x2ddd31a36edbae7d73e9c69747bcd7d542645fcd87dc5f9655208105717a88dc",
      "0x41a2bb693ee13215dd19ccc124821d512ec96679f1b244cadcb32848c9dd2a98",
      "0xb3de95b8193c529c5f8d49a7cdfd7d373784917259eaf3b281e466c5d3dd9d65",
      "0x77715dfe85b5f1faa09695c8abfcfe7d871792e7f0c363d4394bafcd7fd9f059",
      "0x18588c763de2450c80630040200dd2cc440f5d339352f93382b7e7e765f22f3a",
      "0x388a91cba18c21bdf73cebd69592276a36eff7a8373b0e66ea0ae983441633ab",
      "0xf09065a72ed7f56008eb53f87852e3b240821a1709955c23c0aeb23646e6580f",
      "0x58cee441d1bc33b856eae88207d1c8e43f3f0468ceb065ddf9b8d765d5ab163a",
      "0xed0226d5364569e818dbf5b755a762ddcb1ee819d783dee874add199466a6239",
      "0xd0da3a334732122d3afd7767408ed1dd7272bccf5c7ffada4f99a50b3db5bdab",
      "0x784c1a17cea90c7e83fc56afe28c760f01ce6fef009c74cd1ec1ce73f6934589",
      "0xdc9182edfbff1b7b9055fd67f98bca7e5fead6b4495ae1cc7c07d33d177b12bf",
      "0x78767d9d9edc88436734808aff30829cae7a406c1058d6947ccc3f5bd5e9b960",
      "0x670c7ecdd5ab01e7cec134c62d180f72b055a10c39d589670e41836872047727",
      "0xb1bb1974ae7776ac91cf9cc658c22948b70476bee044a28a27dcf4d1402328cf",
      "0x0a752ad8fa17d7c472a65f5485c19cd81f0a22e9283e9786c9703df48aa0aa65",
      "0xebd341bd05b22d621aa05ed345f6c31d274322ff0c9b318f19e7751ef9e78817",
      "0x5850c11ef77d5a9a16b593c6689562269707573d8ee8f473cef40fffa00facda",
      "0x81034c2bba280a5d90c068e632bb7c8b1912afc041ed5c7d22221405ebf12e86",
      "0x176f93fc1c202f1e27d69e5feee6f1c88294b0293a4cfc141bcf3dad5bcd5e39",
      "0x498097cf5f6d2dedb8b0c6951805a4965578562f81cd9d57fbe66e96668705e8",
      "0x29523fc5ca12442580e1b73fd995c069ae07205b306f15ab2a8f0eb7c82a8f97",
      "0x573e6a0baf20c7c8dd313aed0b4effbbba7d8df0583a546c91ce893a7c68791f",
      "0xe7b2922fd15870c9a28cf7356890a8690a6e479b5107afe934bcef6da611c7a4",
      "0xc816dabe0b7a7521d34a2e7514a4667085c85966742daa08a7306fd7365d31d6",
      "0xf11769e5da612f5392b53908210ee5904178489b2261b406725df312ff119493",
      "0x2689a793f7b8e7319bb3d5e2fc57b5b9011eb1d90c1634362135f8f4cb2c02e1",
      "0xa2aefc48a9a5a4c05c266bb99aa5b1a765c0ae9b5748a5301e318f2acc453fca",
      "0x212718c05526899985fe7405dd1877c0c3924076d9f657843cc27f2cf497e4d3",
      "0x6edd409719cc68f329316a0f68e8f61dd9983e4d656fa67e5de108e518fa4a64",
      "0x4a26cd683755c66355bccbb528ffc2fe1b4c1f882d22f367513145006b4cd038",
      "0xf4705d74c67294578b41f385078a0fa0f324bc53cfab305335cc6b39006770e1",
      "0x291ff5646277d7235daae20d1bf048782c3fa64e3563b6536ce4f611c88f095e",
      "0x02e89704706da2f4c208b8890fe960680b4e2501da2d6850523af79fa5f3a748",
      "0x7e604b84b60f3ec9284b8a39d9bed7da21757e82f0a3916b4b87abb4d763dedf",
      "0x4040a6e2c48ce322ab1df59c1a50468f5bbcf0f87c9a155328ff283d94cae900",
      "0xea5fd914f2e3cae1d5afd6dc240c2cd417ba2ede831b533e16a8dfb558dac71d",
      "0x92aa8ca02d2962dcc248942c5a9198604dac790843eb35e6af106c7007adba2c",
      "0x549bdb08baa6a337ae4d6ec09b3021185c3aec9dc0b05e0e1def7e5282666676",
      "0x8773d9c33e0883e8600a818b445c38f6503daef4357abd6fd5b9d1844bb7ddc2",
      "0x862cdb6453f40bf29677ef9ccf01151f399913c0f004926169f999f7592fa756",
      "0xa93839082cca19212373b6f594a780e6edafb0bec728805686c1412c13ac2060",
      "0x8f7d3692697b172071c90b45e5b9dd3d7f7e18aea6a8e1454629a65d37272884",
      "0x055f665524b02885c5057bb14e905770a5d63d456e14c2c691ba72f74a9d7301",
      "0x269955aac60f99cc4f91d6cb8633e2dfce454aca31a0f9ced66125c9f37799de",
      "0xa72340079ac763eb20a84edbbfe11cb784b8c43d3709c951bd77799d58b14c52",
      "0x4a726a395dadc0c2fc710bb62adec05c6faa0035478e793576969d2a03a5cd6f",
      "0x81fba18aaf672e8096e395920e2761e00f834c8e617814679d2433778f919685",
      "0xeb39e1ef6b19fbc06d3e3a4ab9dad66b3905e7f2990552dbbb018bff9c29bb4a",
      "0xe12a340e5e32db22a2420be48a7ba98371a76d8a20dd4e0d29ea4cd6791a666e",
      "0x33ef57231dcdf62f8a6dcf4370e293338ba80e045db5914360c96ecd2a5261ec",
      "0x0d5a76f36c196b0ddf76fae851bfcefe4e4a0e309ab9b71f62677296338c20c9",
      "0xd73619dcb8454dc1107417d25d10bcc44984a909d624f82b6840a20d387ce5f9",
      "0x7561ec62026e217c124038873990b91529bf9412af5496f0a724604ad46b9907",
      "0xfbada822b4e53d77064e4770104ec1ffefd1ad12841525302a7a18ccab440c90",
      "0x8f733d48002edb0fda610e575db2fdf34b590972b37ec82ee142dc786d3cc1ae",
      "0x04d9f7693027ef474b8593b65fb0e1c62d34148855df5bdd9fac7746c5d46c16",
      "0xdd166fb8fb6cb085ac9de88af9e2943863e0bcae7f478ba873836b8260ff08d0",
      "0x62e406d15ca4f1391dab29cf4b1bf5f7824c66c7228595c4e47b5fe6e5bb2acc",
      "0x40833ef10ed6864c943d2e8d7488aef76ff1342e7cda15fb13b2b17c2468d628",
      "0x33210aa70ba342d3ab4a55198a16ee583e2124afe7e4b0bb7fcb25f23bef78e3",
      "0xad8e06d4d5dc41881ecb16a7c05c8639cb489191670ef551f7f780fe0f505bea",
      "0xcda04ee42c4d6bd78d153c6c523c29e11904b3314febb0bd46f2de938d109633",
      "0x8b32c29d86215305be199123a2c60c93f138295e3cc8a162fa3d16be4e6b3a64",
      "0x25052c2a81bdaac9a54d410674c7e7a9a9068cf5425095dfdf1eb37b4a9de2e0",
      "0x3833f04b46e3ae6afb26c4dfa4a4d6022212215bfe673b8b2357bfb9c3751fe9",
      "0xb80a32d4c6218d001be5248ed3558e87c050ba17c4d166ab6a5033631adfed1c",
      "0x248d1ff2013e18738ad24da5fe74ff4b880be372f9198c8ac1412fe9c2662407",
      "0x148d3fb36175e6831d5e9ed3c7843f7d0ecf8c35877f13ebce6fc30cb18f6be5",
      "0x39f1049b10d6fc55715b9fbd7d5a7ab266bd100114df77d5eb326d4ed31e915e",
      "0x860c0d9548f284846d1208022c40f386319f490091a6927284892f076ddcc4b1",
      "0x37002e6d297e248f3fb4a02b2b7e5fc0d6e42975ccc8509e6f698a644265ffe4",
      "0xc647e4bfadae7cec2f65344ac07517d1395c548d222183424bd5e394e8497a6d",
      "0x293b0cdb204865ecb6bccb563045aa128bce062614c9fa517239998fdc63e35e",
      "0xe2fa3f5fe5ce9825a3b4108b9a15ca18bac7287483708f46d34a35b170c86ef9",
      "0xb584de7f7915432f140308a18455dbcc65c713c8cf7238abbcad0ad7fea07a95",
      "0xb267956085faabf5ba690febc33fcfcd3fa2436b52bf6fd70214aee1e5f417ce",
      "0x8eb14a0256f0a522be806156c08c45853eaa91cf9fa3a75704d02a097ff087ca",
      "0x3c982aac39974ad7e9733ba81d046f1e4670d2c1e968d5e57d308a09846d9972",
      "0x5413c7801377b66cb2589a226c8a6ba2a8d47717ac80612d0318ad05cbf79eb4",
      "0xfa0f4628be9c75bd681410145a6787e7f37bce714a49c406082d1b6b29092949",
      "0xa00e9218d6ab5c3ced248dbc8c10d008d7a6a0fe1b38c53d6bf1be3f7a3f03c5",
      "0x2797114664580868022cac669d06015f6ff42f2a61be728b5a1bb04e9ff15cfe",
      "0xa7f062a93091a88cf09b348e4e7ffaef138a973ffceee6faec5ec6dd7ca53df0",
      "0x4ed235d05c28fa6adde0c2673c78dc75e1a667a8e84472b20f12977d9d9e19aa",
      "0x5196c73be2c20435429d4c6628d74e3e221571fb90dd8f3966fcb7b1e701794d",
      "0x5e1651e0cb90dc29ff0f245d4c45784639b8139ddbeaafc7c0cab2ce603804a4",
      "0x2de2bda0d8c02471eef03a6e493f1b391112a461bd69ca7a80bbba5ec3714c52",
      "0x96259534f1dd71e786b672bbc0b787df91e02f635919a12bb9553f78a958d8a6",
      "0xf3339a60df5b23cda3044251d223f05373a983df150a37b91fe78d1d2408282d",
      "0x6f18ac2920a54a1e38515d049d4b3131a97d5b3b7e7b4c92b5ee63273a260ffa",
      "0x26fc4f573a35aa7892004ab4463d2f98ebdca02e83b9dd00bfdf3fed88b31175",
      "0x11e084fd26a1183475696acc2c8b92095a738d30da6ac86aa28930cbbcfcf920",
      "0x713010c33e4445d7460180aad6a5d89eba400dcec6b2bb54103d002052e6becf",
      "0x8a252703a1e9a0659504195a6df59070822f6e4d88a31933b024c2e4c337fed7",
      "0xe23eb2f3999efd64f2e928868353d5827e783a330f8d4c3f06443a42b8ec8aeb",
      "0x4696fad37bd62d3041b1a7370c3ac2eb65df88183dcbc75343ac95cf3f586269",
      "0x5b9f277d2cc215282c90e6f197e657961d8b0e0e3d72196469a9c381b6c89820",
      "0x1c70a1e5d8bb25b9327297df54c51e16f7fc6e0c78a489ae64c158eb1b17094f",
      "0x29dfdd3cb181260739a8c3b5839425afd9b2719bf7e6cbd5f4f0fe5f7f221bfb",
      "0x397a24fde3371f678005b0fcd84a6a9c8b10e71bae491a48a7505a0ed1ee2afc",
      "0x0f9ddc8f60952fe1a0ea783ac0443dfdaa0a1533beb7aa2158b66e2d174fccd4",
      "0x7a0212557215a89175b83401e2c5e0cd09dfadc6f6f42d071afeb15f429f3b95",
      "0xcfb1a29127e2dfce96805630e9d9d0fc756adcb445af21ca0fea904937c67e4c",
      "0xe8ae81a15211a89acf14b4bb94d129c1774cd367782f8c5e6ab3d7b707d38fa6",
      "0xef1e1e749a185f45ee0156391da82936f1b7047f90393614cc4dafc3d341421a",
      "0x0863a32ac2c290c61ab289b37597893eda70142ec5bbec7c845d90f90142c99f",
      "0x329ea04ec00e0b2444956fdf00f7699ee2316ad38dfefd9fc332615f5536e566",
      "0xc3e0f705195a4d966d95e3347bd56b6146d6acf9ceb14ee22a48350b8c847bd3",
      "0x8a73a0778f83569ed5fdcb0dfcbad54270d4f28f9f330550b503795ab5c06d82",
      "0x33a99e2dc7c126e3a982cd4790e65e38add01e6bab16efed1425bf01fa011df6",
      "0xd6e2bf159c8fbeeb813ff5453ad5e7f90204d425cab48fa0c1a4ff89a2eeadf0",
      "0xb7bd8c97f89070b9b66275c86a62e13baec88d1bad9117a002f174edee7b12c9",
      "0xa1dcf464f63c346ce562818874a4a0df598b6347bbbe1e83dc44431d2c884e67",
      "0x5a76f3508e9464630399dd80467b27d4a41b7371b8dabf498a723c8b5f47661f",
      "0x90f6b3bd805a97dc1f323b16d33fae1b1c1e978101666dd64970ffc7a3cdc38c",
      "0xd873acd0fc109db72b46f806c9bdbbee099d96923878c90696a8df40c376ad86"
    ],
    "transactionsRoot": "0x03c5a11a9e6e124f7fa35b15185c0ad65c8a01c3c8e6ba0ab0f5cd7939765be0",
    "uncles": []
  }
}

[holiman]

Related: #20460

[adamschmideg]

The spec says "return null": https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getblockbyhash

[holiman]

Considering that number affects the transaction execution, (very similar to timestamp), it's relevant to have it there. We should add the number back to the pending block (and propose to get the spec updated)

[karalabe]

Ref for ACD ethereum/pm#148 (comment)

[temandroid]

I think if this is a pending block, we should know its number. Logic of stable open-ethereum-pool is based on this...

[karalabe]

Ok, decision was to revert this and re-publish the pending block number as before and fix the spec.

[1blockologist]

This is back on the 2-week release schedule and a build is being cut today? or what