Big hashes in BlockHashes can fill process memory

[obscuren]

Block hashes have no size limit. Check hash size and kick of bad peers.

@zelig Do we currently have anything against random hashes? (e.g., malicious peer continuously sending unknown hashes)

[fjl]

You can use an array type for hashes. The rlp decoder will reject inputs that do not fit into the array and return an appropriate error message.

type message struct{
        ...
        Hash [32]byte
}

[obscuren]

Indeed. Second question still valid.

[zelig]

yes we do . ish . if a section of hashes

• do not get all blocks from peers OR
• do not get a continuation (further parent hashes toward the known blockchain)
  then after a fix time the chain is killed.
  I will make sure the peer supplying that section is expelled.

[zelig]

This is taken care of by conversion to common.Hash and by other measures