Vendoring fails on projects using the native Golang bindings

[awfm9]

System information

Geth
Version: 1.4.7-stable-667a386d
Protocol Versions: [63 62 61]
Network Id: 1
Go Version: go1.6.2
OS: linux
GOPATH=/home/awishformore/Code/go
GOROOT=/opt/google/go

Expected behaviour

I am using the Golang native contract bindings in a project. The project builds fine. I want to use vendoring to add all dependencies into the repository and have it build in an isolated fashion. Using godep save should add all required dependencies to the vendor folder.

Actual behaviour

godep save misses some cgo dependencies that are located in their own folder. This causes the build to fail with:

vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:43:44: fatal error: libsecp256k1/include/secp256k1.h: No such file or directory
 #include "libsecp256k1/include/secp256k1.h"
                                            ^
compilation terminated.

The problem is described in the following issue on the Godep repository: tools/godep#422

The sqlite library in Go solved the issue by putting the cgo dependencies into the same package as the files that depend on it.

Steps to reproduce the behaviour

• use automatically generated Golang bindings in a project
• bind a contract using the native binding, an address and a backend
• use godep save to save the dependencies in the vendor folder
• attempt a build with go build on Golang version 1.6 or later

[awfm9]

Still an issue.

[LYY]

Still have same issue.

[kjda]

me too! any solutions??

[kc1116]

anyone find a solution to this ?

[lmars]

A temporary solution is to just manually copy the files into vendor:

cp -r \
  "${GOPATH}/src/github.com/ethereum/go-ethereum/crypto/secp256k1/libsecp256k1" \
  "vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/"

[Freyert]

@lmars you ... I can't even... wow... thanks! For any newbz out there like myself who have been privileged enough to grow up on dep ensure you should do a:

go get github.com/ethereum/go-ethereum

before running the above.

[overtfuture]

I think the issue is more along the lines of dep, see this issue: golang/dep#1847

[saan099]

Same thing with govendor.

[zomglings]

Had this error using dep. Thanks @lmars

[ezynda3]

Is there a plan to fix this?

[evd0kim]

@ezynda3 it is more likey golang bug. or dep. or whatever, i encountered the same problems with ledger-related golang code.

[s1na]

According to this comment a simple way of fixing this would be to add a dummy go file in crypto/secp256k1/libsecp256k1/, until the fix is implemented and merged into dep.

[zglzglak47]

if you are using govendor , try "govendor fetch -tree github.com/ethereum/go-ethereum/crypto/secp256k1"

[karalabe]

Hey, so this is a limitation of the Go vendoring ecosystem. The suggested workaround by @zglzglak47 is the correct solution unfortunately. Maybe go 1.11 modules could eventually help, but for now this is an unfortunate limit of Go.

[huahuayu]

if you are using govendor , try "govendor fetch -tree github.com/ethereum/go-ethereum/crypto/secp256k1"

it works!