Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertChain panics when struct tracer is set #30658

Closed
lightclient opened this issue Oct 23, 2024 · 2 comments · Fixed by #30666
Closed

insertChain panics when struct tracer is set #30658

lightclient opened this issue Oct 23, 2024 · 2 comments · Fixed by #30666
Labels

Comments

@lightclient
Copy link
Member

When a tracer is set while calling "insertChain", the client panics. Doesn't seem like OnTxStart is called before process.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x38 pc=0x10155f144]

goroutine 1 [running]:
github.com/ethereum/go-ethereum/eth/tracers/logger.(*StructLogger).OnOpcode(0x14000273290, 0x0, 0x33, 0x1c9c380, 0x2, {0x101ba1de0, 0x14000329b18}, {0x0, 0x0, 0x101506be4?}, ...)
        /Users/matt/dev/go-ethereum/eth/tracers/logger/logger.go:214 +0x644
github.com/ethereum/go-ethereum/core/vm.(*EVMInterpreter).Run(0x140005d5440, 0x140000e69c0, {0x14000038340, 0x20, 0x20}, 0x0)
        /Users/matt/dev/go-ethereum/core/vm/interpreter.go:304 +0x8f0
github.com/ethereum/go-ethereum/core/vm.(*EVM).Call(0x140000f7900, {0x101b93640, 0x140004d8d68}, {0x0, 0xf, 0x3d, 0xf6, 0xd7, 0x32, 0x80, ...}, ...)
        /Users/matt/dev/go-ethereum/core/vm/evm.go:227 +0x780
github.com/ethereum/go-ethereum/core.ProcessBeaconBlockRoot({0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...}, ...)
        /Users/matt/dev/go-ethereum/core/state_processor.go:240 +0x240
github.com/ethereum/go-ethereum/core.(*StateProcessor).Process(0x140004d49e0, 0x1400040f680, 0x14000246f00, {0x140004e6a00, 0x0, 0x0, {0x0, 0x0, 0x0}, 0x0})
        /Users/matt/dev/go-ethereum/core/state_processor.go:80 +0x49c
github.com/ethereum/go-ethereum/core.(*BlockChain).processBlock(0x140000fa408, 0x1400040f680, 0x14000246f00, {0x0?, 0x101ba2438?, 0x1022ebd60?}, 0x1)
        /Users/matt/dev/go-ethereum/core/blockchain.go:1899 +0x220
github.com/ethereum/go-ethereum/core.(*BlockChain).insertChain(0x140000fa408, {0x1400038a9f8, 0x1, 0x1}, 0x1, 0x0)
        /Users/matt/dev/go-ethereum/core/blockchain.go:1818 +0x16ac
github.com/ethereum/go-ethereum/core.(*BlockChain).InsertChain(0x140000fa408, {0x1400038a9f8, 0x1, 0x1})
        /Users/matt/dev/go-ethereum/core/blockchain.go:1601 +0x908
github.com/ethereum/go-ethereum/tests.(*BlockTest).insertBlocks(0x101ba94a8?, 0x140000fa408)
        /Users/matt/dev/go-ethereum/tests/block_test_util.go:238 +0x21c
github.com/ethereum/go-ethereum/tests.(*BlockTest).Run(0x1400037c608, 0x0, {0x1016bf309, 0x4}, 0x0, 0x140004e6a00, 0x140004d1978)
        /Users/matt/dev/go-ethereum/tests/block_test_util.go:162 +0x478
main.blockTestCmd(0x140001fa900)
        /Users/matt/dev/go-ethereum/cmd/evm/blockrunner.go:84 +0x514
github.com/ethereum/go-ethereum/internal/flags.MigrateGlobalFlags.func2.1(0x140001fa900)
        /Users/matt/dev/go-ethereum/internal/flags/helpers.go:99 +0x38
github.com/urfave/cli/v2.(*Command).Run(0x10227f7a0, 0x140001fa900, {0x14000396320, 0x5, 0x5})
        /Users/matt/dev/go-workspace/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:274 +0x5e0
github.com/urfave/cli/v2.(*Command).Run(0x140003482c0, 0x140001fa300, {0x14000152000, 0x7, 0x7})
        /Users/matt/dev/go-workspace/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:267 +0x81c
github.com/urfave/cli/v2.(*App).RunContext(0x140001fc000, {0x101b9c6c0, 0x10231b3e0}, {0x14000152000, 0x7, 0x7})
        /Users/matt/dev/go-workspace/pkg/mod/github.com/urfave/cli/v2@v2.25.7/app.go:332 +0x4f8
github.com/urfave/cli/v2.(*App).Run(...)
        /Users/matt/dev/go-workspace/pkg/mod/github.com/urfave/cli/v2@v2.25.7/app.go:309
main.main()
        /Users/matt/dev/go-ethereum/cmd/evm/main.go:141 +0x4c
exit status 2
@lightclient
Copy link
Member Author

cc @s1na

@s1na
Copy link
Contributor

s1na commented Oct 24, 2024

Yeah the the pre-block processors get the non-wrapped statedb. here is the fix for that: fbd1d19#diff-7ee5f952a6b64b5c8a5db54348910f6e901dcafce4afa172720c40713fe2e78bR80-R88

holiman pushed a commit that referenced this issue Nov 19, 2024
This change makes it so that the wrapped statedb with tracing-hooks is passed to the system call processing

Fixes #30658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants