Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX - Mist shows outdated version numbers #395

Closed
kumavis opened this issue Feb 26, 2015 · 12 comments
Closed

OSX - Mist shows outdated version numbers #395

kumavis opened this issue Feb 26, 2015 · 12 comments

Comments

@kumavis
Copy link
Member

kumavis commented Feb 26, 2015

This is pretty minor, but felt it should be on our radar.

Installer shows POC6
image

Mist.app Shows POC5
image
@tgerring
Copy link
Contributor

Looks like the image was updated in b4de14758964614b6955118164b8916a4c393475

The POC5 string is now updated to POC8 via 44eb6209833adc993dcdec74a8cf3592eeffa4fa

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

@tgerring I'm getting my builds from here https://build.ethdev.com/builds/OSX%20Go%20develop%20branch/
Are these out of date?

@tgerring
Copy link
Contributor

Pinging @caktux for above question about build server

There is a plan to merge the go-build repo (where this issue should really have been opened 😉 ) into go-ethereum proper.

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

Was not aware of the separate repo, makes sense

@caktux
Copy link
Contributor

caktux commented Feb 26, 2015

https://build.ethdev.com/builds/OSX%20Go%20develop%20branch/Mist-OSX-latest.dmg should have the right image and tag

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

unless theres some weird caching going on... That doesn't seem to be the case.
image

@caktux
Copy link
Contributor

caktux commented Feb 26, 2015

uhm.. symlink is ok.. Mist-OSX-latest.dmg -> Mist-OSX-20150226110835-0.8.5-54-a1c830c.dmg

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

Mist-OSX-20150226110835-0.8.5-54-a1c830c.dmg looks like this, so the problem goes deeper:

image

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

If its just the background image this isnt a big deal but i suspect I'm getting old builds

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

is the a1c830c a hash of the build or the latest git commit?

@caktux
Copy link
Contributor

caktux commented Feb 26, 2015

Of the git commit of go-ethereum, you can see the last build report and which commit hash was used here: https://build.ethdev.com/builders/OSX%20Go%20develop%20branch/builds/-1

@kumavis
Copy link
Member Author

kumavis commented Feb 26, 2015

continued on ethereum/go-build#11

tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@timmoreton
Serve light clients by default (ethereum#395)
9c18a15
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
Make LES server not run by default, and tweak related flags (ethereum…
8ab2365 
…#1263)

### Description

This changes the `light.serve` default back to zero so that serving light clients becomes opt-in rather than opt-out.  The reason is that there are many use-cases for running a node that don't involve light clients, and only one use-case that is about serving light clients, so it makes more sense to have it opt-in to avoid people running the light server without realizing it.

### Other changes

* Change `light.maxpeers` default value from 99 back to 100 (the change to 99 was to work around an issue that no longer exists, see below under "Related issues")
* Fix a bug in the logic for the `lightPeers` variable in `SetP2PConfig()` (it was not respecting the default value of LightPeers, leading to incorrect values in the `Maximum peer count` log line and to `MaxPeers` not being increased when it should have been.

### Tested

* Automated tests pass
* Without specifying any flags, LES is off, max peers is 175
* Specifying `--light.serve 100`, LES is on, total max peers is 275, max eth peers is 175, max light peers is 100
* Specifying `--light.serve 100 --light.maxpeers 200`, LES is on, total max peers is 375, max eth peers is 175, max light peers is 200
* Specifying `--light.serve 100 --maxpeers 150`, LES is on, total max peers is 250, max eth peers is 150, max light peers is 100
* Specifying `--light.serve 100 --light.maxpeers 1000 --maxpeers 100`, LES is on, total max peers is 1100, max eth peers is 100, max light peers is 1000 (these are the flag values recommended in the docs for serving light clients, and are based on the fact that if (and only if) you specify both `light.maxpeers` and `maxpeers` then `maxpeers` is assumed to include `light.maxpeers`)

### Related issues

- Closes ethereum#1262
- Additional context: ethereum#395, ethereum#416, ethereum#864 

### Backwards compatibility

Breaking change to the defaults, most notably `--light.serve`, but with limited impact, because in the docs for running a full node we specify `--light.serve`, `--light.maxpeers` and `--maxpeers`, so it's not relying on the defaults anyway.  And for users who are not intending to serve light clients, the new defaults make more sense.
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Dec 9, 2022
@JekaMas
Merge pull request ethereum#395 from maticnetwork/testing-flags
87a2e52 
Restores linters and separate kinds of tests
tanishqjasoria pushed a commit to tanishqjasoria/go-ethereum that referenced this issue Oct 31, 2023
@0xmountaintop @noel2004
@lispc @Thegaram
feat(rollup): add circuits capacity checker (ethereum#321)
2f9edf7 
* add proof for predeployed storages

* reverse inneeded code

* update for mainbranch merging

* add pertx storage trace

* dummy tx proof

* add txstorage trace

* add coinbase storage as trace

* enable (sync) tracing by default

* basic

* init cgo framework

* fix break loop

* integrate the right zkevm version (ethereum#323)

* finish rust codes

* use dylib (ethereum#325)

* flip

* ?

* use cdylib

* revert

* fix

* apply_tx

* rename

* fixing types

fixing types

fixing types

* clean up

* ExecutionResults (ethereum#328)

* filling

* filling

* more

* clean up

* filling

* coinbase

* add

* MPTWitness

* ExecutionResults WIP

* L1fee

L1fee

* sender

* to

* Failed & ReturnValue

* createdAcc & after

* remove MPTWitness

* txStorageTrace

* add FeeRecipient

* add StorageTrace

* fix FFI types

* better logger

* cargo fmt

* fix

* add build tags

* update Makefile

* fix library

* improve ld path

* correctly deal with circuit_capacity_checker returned result

* fix return value

* update cargo (ethereum#333)

* update cargo

* update

* update go

* refactor

* raname `circuits capacity checker` to `circuit capacity checker`

* some refactorings

* [Fix] storage proof generation in capacity checker (ethereum#348)

* make per-tx storage and deletion proof work

* format

* fix misplaced markdeletion

---------

Co-authored-by: HAOYUatHZ <haoyu@protonmail.com>

* docker (ethereum#363)

* update Dockerfile

* build: update go version to 1.19

* update

* fix

* fix

* try

* simplify

* revert go version

update l2geth Dockerfiles

* fix

* fix coinbase

* fix (ethereum#369)

* format

* Update version.go

* address comments

* Capacity refactor (ethereum#374)

* init

* id

* support multiple instances

* fix id

* fix conflicts

* refactor to use same codes (ethereum#379)

* re-init

* WIP

* WIP

* refactor

* go

* minor

* fix storage proof of l1gas price oracle

* move 1

* move 2

* move 3

* move 4

* move 5

move 5

* move 6

move 6

* move 7

* move 8

* move 9

* move 10

* clean up

clean up

---------

Co-authored-by: Ho Vei <noelwei@gmail.com>

* finish basic

* minor

* config capacity check in block_validator (ethereum#380)

* init

* done

ref

* fix tests

fix tests

fix tests

fix tests

* add more comments

* apply_block

* improve logs

* cargo fmt

* Capacity big refactor (ethereum#383)

* CreateTraceEnv

* WIP

* draft

more

fix

* for test

* fortet

* clean up

* add more comments

* goimports -local github.com/scroll-tech/go-ethereum -w .

* fix typos

* attempt 1

* attempt 2

* attempt 3

* gogogo

* clean up

* fix

* fix

* rename

* minor

* fix

* minor

* minor

* improve doc

* use dedicated `checkCircuitCapacity` flag (ethereum#394)

* refactor

* fix

* add lock

* [feat] capacity checking: upgrade libzkp (ethereum#395)

* upgrade

* upgrade libzkp

* write RowConsumption (ethereum#396)

* write RowConsumption

* name alignments

* revert some formatting

* add lock to CircuitCapacityChecker in BlockValidator

* remove mutex pointer

* improve github workflow

* improve

* store row consumption in mining (ethereum#397)

* prepare

* finish

* add more logs

* mark `ApplyBlock` as ready

* update libzkp (ethereum#401)

* fix

* Capacity detail (ethereum#402)

* fix(block-validation): consider skipping in ValidateL1Messages (ethereum#405)

* fix(block-validation): consider skipping in ValidateL1Messages

* fix(block): consider skipping in L1MessageCount

* fix l1 validation tests

* fix NumL1Messages

* fix impl.go return types

fix

* better error handling (ethereum#407)

* add

add

* add

* add

* add

* add

* cargo fmt

* add

* update

* add

* WIP

* minor

* gogogo

* gogogo

* fix

* fix

* fix

* cargo clippy

* improve

* improve

* creation lock (ethereum#408)

* creation lock

* update

* Debug log (ethereum#409)

* add more logs

* more

* more

* fix

* improve

* Update cmd/utils/flags.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* refactor worker.commit()

* avoid re-calculate

* txpool ccc err handling (ethereum#411)

* more explicit error comments

* add more logs

* fix unnecessary commit

* add more logs

* fix `ineffassign`

* add more comments

* log id for `NewCircuitCapacityChecker` (ethereum#414)

add log to `NewCircuitCapacityChecker`

* Persist skip info for block where all L1 msgs are skipped (ethereum#415)

persist skip info for block where all L1 msgs are skipped

* Update version.go

---------

Co-authored-by: Ho Vei <noelwei@gmail.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@caktux @tgerring @kumavis