Closing miner blocks

[ebuchman]

This blocks: https://github.com/ethereum/eth-go/blob/master/ethminer/miner.go#L133

Ctrl-C won't let me shut down the program if I'm mining, because sending over the powQuitChan apparently blocks. If I remove that line, everything works fine, but it doesn't seem right. Even if I drain the channel first before sending on it, it still blocks. I don't understand it. Maybe you do? Or maybe we can just remove it?

[obscuren]

Fixed on develop

[ebuchman]

I had tried just closing the channel. It panics instead:

2014/07/01 06:13:47 [POW] Hashing @114khash
^C2014/07/01 06:13:51 [CLI] Shutting down (interrupt) ...
2014/07/01 06:13:51 [MINER] Stopping...
panic: runtime error: send on closed channel

goroutine 24 [running]:
runtime.panic(0x452e6c0, 0x4c0805e)
        /usr/local/Cellar/go/1.2.2/libexec/src/pkg/runtime/panic.c:266 +0xb6
github.com/ethereum/eth-go/ethutil.func·001(0xc210537080)
        /Users/BatBuddha/Programming/goApps/src/github.com/ethereum/eth-go/ethutil/reactor.go:21 +0x46
created by github.com/ethereum/eth-go/ethutil.(*ReactorEvent).Post
        /Users/BatBuddha/Programming/goApps/src/github.com/ethereum/eth-go/ethutil/reactor.go:22 +0xf6

goroutine 1 [chan receive]:
main.main()
        /Users/BatBuddha/Programming/goApps/src/github.com/ethereum/go-ethereum/ethereum/main.go:51 +0x241

goroutine 3 [syscall]:
os/signal.loop()
        /usr/local/Cellar/go/1.2.2/libexec/src/pkg/os/signal/signal_unix.go:21 +0x1e
created by os/signal.init·1
        /usr/local/Cellar/go/1.2.2/libexec/src/pkg/os/signal/signal_unix.go:27 +0x31

goroutine 4 [syscall]:
runtime.goexit()
        /usr/local/Cellar/go/1.2.2/libexec/src/pkg/runtime/proc.c:1394

etc.

[obscuren]

Thank you. I'll investigate further.