-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics collecting and reporting support #1321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8475416
to
e8d2314
Compare
Conflicts: cmd/geth/admin.go
Conflicts: ethdb/database.go
2f36c1f
to
92ef33d
Compare
obscuren
added a commit
that referenced
this pull request
Jun 25, 2015
Metrics collecting and reporting support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is that - similar to logs - we should be able to add metrics collection to any part of the code without fancy constructs (counter variables, exporting them through public interfaces, adding them to the APIs, consoles, RCP/IPC, etc), and have the just work, be queryable and visualizable.
To that extent, this PR currently adds support for two metric types:
To create and use a meter and/or timer:
These are automatically registered into a central metrics registry and can be queried from the javascript console through
debug.metrics()
for a user friendly pre-formatted output:Or in a raw format for visualization, reporting, processing, monitoring, etc. via
debug.metrics(true)
:The PR furthermore introduces a new command to geth,
geth monitor
, that allows the real time visualization of any of these metrics:The monitor will plot all requested metrics on individual line charts, expanding user patterns:
geth monitor core/BlockInsertions/Percentiles/80
: a single metric to chartgeth monitor core/BlockInsertions/Percentiles/25 core/BlockInsertions/Percentiles/95
: two metrics, side by sidegeth monitor core/BlockInsertions/Percentiles/25,80,95
: three metrics, with a common rootgeth monitor p2p
: expand and display all metrics under the p2p collectiongeth monitor eth/db/block,state/Reads,Writes
: various metrics with various wildcards (image above)The charts are automatically scaled below 1000, and the scaling units inserted into the chart labels. The colors of the charts are also updated depending on the scale, ranging in [blue, cyan, green, yellow, red], with blue being none scaled, and every consecutive one a 1000 multiplier.