-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getTransactionReceipt RPC support #1397
Conversation
@obscuren The following error prints in the logs, but it appears to decode fine. Thoughts?
|
You need to decode in to |
Taylor i just tried you method, but you're using the names wrong. e.g.: BlockHash: "0x1a5c947185813115f832d668364543552d54ff56c7c395c5e8a30348ceb8c5e0"
BlockNumber: "0x4817"
ContractAddress: null
CumulativeGasUsed: "0x58be"
GasUsed: "0x5a3c"
Logs: null
TransactionHash: "0x2d173587dbe656eb77c3c6a9872e7400113281f7a4df17eed44f5cd39c943be3"
TransactionIndex: "0x0" Additional empty logs, should be an empty array not Could you fix that? |
If you fixed the above i can re-run my web3 integration: |
v := NewReceiptRes(rec) | ||
v.BlockHash = newHexData(bhash) | ||
v.BlockNumber = newHexNum(bnum) | ||
v.GasUsed = newHexNum(tx.Gas().Bytes()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. I'll fix this in a future PR. This should be set based on receipt.cumGas - previousReceipt.cumGas
getTransactionReceipt RPC support
Guys why you merged it? it has significant errors, as i stated |
@frozeman they are because it's natively implemented. We're waiting for |
Description Improve reliability from the ethstats module The connectionWrapper was cherrypicked from go-ethereum upstream: ethereum@82a9e11 (ethereum#21404) Other changes Validator injecting its version to the proxy stats chunk Tested Manually in a local testnet Related issues Fixes ethereum#1395 Fixes ethereum#1397 Backwards compatibility Yes
#1042 #1306