core: remove redundant storage of transactions and receipts #14801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachnid
reviewed
Jul 13, 2017
core/database_util.go
Outdated
| if blockHash != (common.Hash{}) { | ||
| body := GetBody(db, blockHash, blockNumber) | ||
| if body == nil || len(body.Transactions) <= int(txIndex) { | ||
| log.Error("Transaction refereced missing", "number", blockNumber, "hash", blockHash, "index", txIndex) |
core/database_util.go
Outdated
| if err = batch.Put(tx.Hash().Bytes(), data); err != nil { | ||
| return err | ||
| } | ||
| // Encode and queue up the transaction metadata for storage | ||
| meta := struct { |
There was a problem hiding this comment.
Can you break this out into a top-level struct?
There was a problem hiding this comment.
Sure, makes sense if we have a global accessor for it.
Arachnid
approved these changes
Jul 13, 2017
zsfelfoldi
approved these changes
Jul 14, 2017
| if list != nil { | ||
| // Retrieve all the receipts belonging to this block and write the loopup table | ||
| if _, err := GetBlockReceipts(ctx, pool.odr, hash, number); err != nil { // ODR caches, ignore results |
There was a problem hiding this comment.
Just a quick note: in the long run we'll need ODR versions of GetTransaction and GetReceipt, and when we have those, we can remove this block receipts request here since they will be downloaded on demand if the app needs them. Until we have and ODR request for lookup entries, we can leave it like this.
fjl
reviewed
Jul 14, 2017
|
It's for both transactions and receipts. |
|
Yes, but the receipt index is always equal to the transaction index. |
|
LookupEntry sounds fine for me too but we could also call it TxHashLookup. |
Arachnid
approved these changes
Jul 14, 2017
|
WOW! That's some major optimizations :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces fast sync time by about 30 minutes on my machine from 2:15 to 1:45, and also reduces the overall database size from 26.3GB to 14.9GB.
The change is that currently we're storing each transaction twice, once in the block body, once individually to allow hash lookups. In addition, we're also storing the block metadata (hash, number, index) of each such transaction with its hash. (Similarly, we store each receipt twice, once as a collection for the block, once individually). But: