-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth,internal: add eth_chainId method to PublicEthereumApi JSONRPC #15002
Conversation
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
Would be nice to have an EIP for it before adding methods to the standardized |
Good to see this, I was facing with same problem when using Web3js, which was using the net_getId by default, just created a EIP694 |
Please find an EIP PR here: ethereum/EIPs#695 |
The proper way to retrieve the chainID is:
Although the EIP is not finalized it is likely that a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parity just added this method aswell, looks good to me.
Actually, hold that. How will this respond when doing e.g. a full-sync, before reaching EIP-155?
It will |
whats the status on this? seems like a stale PR. did chainId make it in somewhere else? |
ESN ( https://ethersocial.org ) using customized RPC-API for using Metamask. by using this customized RPC-API.
|
Closing in favor of #17617 |
I'm stealing @sorpaas words from his congruent Parity client PR:
Recently merged the same endpoint to ETC's go-ethereum: ethereumproject/go-ethereum#336