core/vm: make contract creation failed if address collisions #15038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
address_collision_handle
branch
from
e7274b8 to
47adf20
Compare
Member
|
Please ping us before you start working on something, especially on metropolis stuff with deadlines. I already have this implemented locally, just debating consensus issues between different implementations. |
Member
|
Otherwise the code is ok :) |
rjl493456442
force-pushed
the
address_collision_handle
branch
from
47adf20 to
ebe6f28
Compare
Member
|
Actually, not fully ok. Anyway, there's a cornercase that needs to be figured out before we can finalize this. ethereum/pm#21 (comment) |
Member
Author
|
It is fine. I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ethereum EIP689