core, eth, les: fix messy code #15367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
force-pushed
the
fix-post-les2-stuff
branch
from
20b3c35 to
192d233
Compare
zsfelfoldi
requested changes
Oct 24, 2017
core/chain_indexer.go
Outdated
| if h := FindCommonAncestor(c.chainDb, prevHeader, header); h != nil { | ||
| c.newHead(h.Number.Uint64(), true) | ||
| } | ||
| c.newHead(FindCommonAncestor(c.chainDb, prevHeader, header).Number.Uint64(), true) |
There was a problem hiding this comment.
This is not correct, it will panic after light client checkpoint syncing. I think that is the only case where you don't have a common ancestor in the header chain. We can think about a nicer workaround for this corner case but this one will definitely break it.
zsfelfoldi
approved these changes
Oct 25, 2017
vincentserpoul
pushed a commit
to vincentserpoul/go-ethereum
that referenced
this pull request
Nov 22, 2017
* core, eth, les: fix messy code * les: fixed tx status test and rlp encoding * core: add a workaround for light sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.