Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove stray account creations in state transition #16470

Merged
merged 1 commit into from
Apr 10, 2018
Merged

core: remove stray account creations in state transition #16470

merged 1 commit into from
Apr 10, 2018

Commits on Apr 10, 2018

  1. core: remove stray account creations in state transition 

    The 'from' and 'to' methods on StateTransitions are reader methods and
shouldn't have inadvertent side effects on state.

It is safe to remove the check in 'from' because account existence is
implicitly checked by the nonce and balance checks. If the account has
non-zero balance or nonce, it must exist. Even if the sender account has
nonce zero at the start of the state transition or no balance, the nonce
is incremented before execution and the account will be created at that
time.

It is safe to remove the check in 'to' because the EVM creates the
account if necessary.

Fixes ethereum#15119
    @fjl
    fjl committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    e8c30e8 View commit details
    Browse the repository at this point in the history